This repository was archived by the owner on Jul 19, 2019. It is now read-only.
Open
Conversation
…nitcally to the Enter key for selecting menu items
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically a 1:1 port of the existing PR #186 but based on the more recent ES6-ish codebase, with the
selectOnTabprop optional and defaulted tofalse, and without the extraselectionMethodargument to theonSelectmethod. Big props to @Daniel15 for having already tackled this problem.I would love to use the vanilla react-autocomplete but the existing
selectOnBlurbehavior is just not acceptable for my deliverables. Selecting explicitly on Click/Enter/Tab is more expected by my users than any blur event.